PMD Results

The following document contains the results of PMD 7.17.0.

Violations By Priority

Priority 2

org/dbunit/dataset/filter/PatternMatcher.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 281

Priority 3

org/dbunit/IOperationListener.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'connectionRetrieved': the method is declared in an interface type 44
UnnecessaryModifier Unnecessary modifier 'public' on method 'operationSetUpFinished': the method is declared in an interface type 51
UnnecessaryModifier Unnecessary modifier 'public' on method 'operationTearDownFinished': the method is declared in an interface type 58
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_OP_OPERATION_LISTENER': the field is declared in an interface type 68

org/dbunit/ant/DbUnitTask.java

Rule Violation Line
PrimitiveWrapperInstantiation Do not use `new Integer(...)`, prefer `Integer.valueOf(...)` 556
PrimitiveWrapperInstantiation Do not use `new Integer(...)`, prefer `Integer.valueOf(...)` 561

org/dbunit/ant/DbUnitTaskStep.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'execute': the method is declared in an interface type 38
UnnecessaryModifier Unnecessary modifier 'public' on method 'getLogMessage': the method is declared in an interface type 40

org/dbunit/assertion/DifferenceListener.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'handle': the method is declared in an interface type 43

org/dbunit/assertion/FailureFactory.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'createFailure': the method is declared in an interface type 43
UnnecessaryModifier Unnecessary modifier 'public' on method 'createFailure': the method is declared in an interface type 50

org/dbunit/assertion/FailureHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getAdditionalInfo': the method is declared in an interface type 46

org/dbunit/database/DatabaseConfig.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 265268
UnnecessaryReturn Unnecessary return statement 294
PrimitiveWrapperInstantiation Do not use `new Integer(...)`, prefer `Integer.valueOf(...)` 386

org/dbunit/database/DatabaseDataSet.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 401404

org/dbunit/database/IDatabaseConnection.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getConnection': the method is declared in an interface type 45
UnnecessaryModifier Unnecessary modifier 'public' on method 'getSchema': the method is declared in an interface type 50
UnnecessaryModifier Unnecessary modifier 'public' on method 'close': the method is declared in an interface type 55
UnnecessaryModifier Unnecessary modifier 'public' on method 'createDataSet': the method is declared in an interface type 60
UnnecessaryModifier Unnecessary modifier 'public' on method 'createDataSet': the method is declared in an interface type 70
UnnecessaryModifier Unnecessary modifier 'public' on method 'createQueryTable': the method is declared in an interface type 83
UnnecessaryModifier Unnecessary modifier 'public' on method 'createTable': the method is declared in an interface type 96
UnnecessaryModifier Unnecessary modifier 'public' on method 'createTable': the method is declared in an interface type 105
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRowCount': the method is declared in an interface type 114
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRowCount': the method is declared in an interface type 123
UnnecessaryModifier Unnecessary modifier 'public' on method 'getConfig': the method is declared in an interface type 128
UnnecessaryModifier Unnecessary modifier 'public' on method 'getStatementFactory': the method is declared in an interface type 133

org/dbunit/database/IMetadataHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'matches': the method is declared in an interface type 63
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPrimaryKeys': the method is declared in an interface type 126

org/dbunit/database/IResultSetTable.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'close': the method is declared in an interface type 34

org/dbunit/database/IResultSetTableFactory.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'createTable': the method is declared in an interface type 37
UnnecessaryModifier Unnecessary modifier 'public' on method 'createTable': the method is declared in an interface type 40
UnnecessaryModifier Unnecessary modifier 'public' on method 'createTable': the method is declared in an interface type 51

org/dbunit/database/ScrollableResultSetTable.java

Rule Violation Line
CheckResultSet Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 61
CheckResultSet Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 83
CheckResultSet Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 105

org/dbunit/dataset/CompositeDataSet.java

Rule Violation Line
UnnecessaryReturn Unnecessary return statement 216

org/dbunit/dataset/DefaultTable.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 144148

org/dbunit/dataset/IDataSet.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableNames': the method is declared in an interface type 38
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableMetaData': the method is declared in an interface type 49
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTable': the method is declared in an interface type 61
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTables': the method is declared in an interface type 69
UnnecessaryModifier Unnecessary modifier 'public' on method 'iterator': the method is declared in an interface type 74
UnnecessaryModifier Unnecessary modifier 'public' on method 'reverseIterator': the method is declared in an interface type 79
UnnecessaryModifier Unnecessary modifier 'public' on method 'isCaseSensitiveTableNames': the method is declared in an interface type 86

org/dbunit/dataset/IRowValueProvider.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getColumnValue': the method is declared in an interface type 40

org/dbunit/dataset/ITable.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_VALUE': the field is declared in an interface type 34
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableMetaData': the method is declared in an interface type 39
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRowCount': the method is declared in an interface type 44
UnnecessaryModifier Unnecessary modifier 'public' on method 'getValue': the method is declared in an interface type 57

org/dbunit/dataset/ITableIterator.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'next': the method is declared in an interface type 39
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableMetaData': the method is declared in an interface type 44
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTable': the method is declared in an interface type 49

org/dbunit/dataset/ITableMetaData.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableName': the method is declared in an interface type 38
UnnecessaryModifier Unnecessary modifier 'public' on method 'getColumns': the method is declared in an interface type 50
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPrimaryKeys': the method is declared in an interface type 57
UnnecessaryModifier Unnecessary modifier 'public' on method 'getColumnIndex': the method is declared in an interface type 67

org/dbunit/dataset/common/handlers/AbstractPipelineComponent.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 9192

org/dbunit/dataset/common/handlers/Handler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'handle': the method is declared in an interface type 32
UnnecessaryModifier Unnecessary modifier 'public' on method 'canHandle': the method is declared in an interface type 33
UnnecessaryModifier Unnecessary modifier 'public' on method 'noMoreInput': the method is declared in an interface type 34
UnnecessaryModifier Unnecessary modifier 'public' on method 'allowForNoMoreInput': the method is declared in an interface type 35

org/dbunit/dataset/common/handlers/WhitespacesHandler.java

Rule Violation Line
SimplifiedTernary This conditional expression can be simplified with || or && 59

org/dbunit/dataset/datatype/DateDataType.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 108111

org/dbunit/dataset/datatype/IDataTypeFactory.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'createDataType': the method is declared in an interface type 41
UnnecessaryModifier Unnecessary modifier 'public' on method 'createDataType': the method is declared in an interface type 65

org/dbunit/dataset/datatype/IDbProductRelatable.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getValidDbProducts': the method is declared in an interface type 43

org/dbunit/dataset/datatype/NumberDataType.java

Rule Violation Line
AvoidDecimalLiteralsInBigDecimalConstructor Avoid creating BigDecimal with a decimal (float/double) literal. Use a String literal 43
AvoidDecimalLiteralsInBigDecimalConstructor Avoid creating BigDecimal with a decimal (float/double) literal. Use a String literal 44

org/dbunit/dataset/datatype/TimestampDataType.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 128131

org/dbunit/dataset/datatype/ToleratedDeltaMap.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'getToleratedDeltasNullSafe': private methods cannot be overridden 68

org/dbunit/dataset/excel/XlsTable.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 262266

org/dbunit/dataset/filter/IColumnFilter.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'accept': the method is declared in an interface type 46

org/dbunit/dataset/filter/IRowFilter.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'accept': the method is declared in an interface type 39

org/dbunit/dataset/filter/ITableFilter.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableNames': the method is declared in an interface type 43
UnnecessaryModifier Unnecessary modifier 'public' on method 'iterator': the method is declared in an interface type 50

org/dbunit/dataset/filter/ITableFilterSimple.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'accept': the method is declared in an interface type 38

org/dbunit/dataset/stream/IDataSetConsumer.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'startDataSet': the method is declared in an interface type 40
UnnecessaryModifier Unnecessary modifier 'public' on method 'endDataSet': the method is declared in an interface type 46
UnnecessaryModifier Unnecessary modifier 'public' on method 'startTable': the method is declared in an interface type 55
UnnecessaryModifier Unnecessary modifier 'public' on method 'endTable': the method is declared in an interface type 60
UnnecessaryModifier Unnecessary modifier 'public' on method 'row': the method is declared in an interface type 67

org/dbunit/dataset/stream/IDataSetProducer.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setConsumer': the method is declared in an interface type 35
UnnecessaryModifier Unnecessary modifier 'public' on method 'produce': the method is declared in an interface type 46

org/dbunit/dataset/stream/StreamingIterator.java

Rule Violation Line
EmptyControlStatement Empty while statement 120121

org/dbunit/dataset/xml/XmlProducer.java

Rule Violation Line
UnnecessaryReturn Unnecessary return statement 265
UnnecessaryReturn Unnecessary return statement 345

org/dbunit/ext/db2/Db2MetadataHandler.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 97103

org/dbunit/ext/mssql/MsSqlDataTypeFactory.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 7578

org/dbunit/ext/mysql/MySqlDataTypeFactory.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 99101

org/dbunit/operation/AbstractBatchOperation.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 226232

org/dbunit/operation/RefreshOperation.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 119125
CheckResultSet Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 363

org/dbunit/util/Base64.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'BAD_ENCODING'. 124
UnusedLocalVariable Avoid unused local variables such as 'ib'. 154
EmptyControlStatement Empty while statement 155157
UnusedPrivateMethod Avoid unused private methods such as 'encode3to4(byte[])'. 179

org/dbunit/util/CollectionsHelper.java

Rule Violation Line
UnnecessarySemicolon Unnecessary semicolon 96

org/dbunit/util/SQLHelper.java

Rule Violation Line
CheckResultSet Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 77
CollapsibleIfStatements This if statement could be combined with its parent 612613
CollapsibleIfStatements This if statement could be combined with its parent 629630
UnnecessaryModifier Unnecessary modifier 'final' on method 'isEscaped': private methods cannot be overridden 640

org/dbunit/util/TableFormatter.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'getPadCharArray': private methods cannot be overridden 86
UnnecessaryModifier Unnecessary modifier 'final' on method 'pad': private methods cannot be overridden 104

org/dbunit/util/concurrent/BoundedChannel.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'capacity': the method is declared in an interface type 37

org/dbunit/util/concurrent/Channel.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'put': the method is declared in an interface type 249
UnnecessaryModifier Unnecessary modifier 'public' on method 'offer': the method is declared in an interface type 267
UnnecessaryModifier Unnecessary modifier 'public' on method 'take': the method is declared in an interface type 280
UnnecessaryModifier Unnecessary modifier 'public' on method 'poll': the method is declared in an interface type 299
UnnecessaryModifier Unnecessary modifier 'public' on method 'peek': the method is declared in an interface type 306

org/dbunit/util/concurrent/Executor.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'execute': the method is declared in an interface type 69

org/dbunit/util/concurrent/PropertyChangeMulticaster.java

Rule Violation Line
PrimitiveWrapperInstantiation Do not use `new Boolean(...)`, prefer `Boolean.valueOf` 419
PrimitiveWrapperInstantiation Do not use `new Boolean(...)`, prefer `Boolean.valueOf` 420

org/dbunit/util/concurrent/Puttable.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'put': the method is declared in an interface type 50
UnnecessaryModifier Unnecessary modifier 'public' on method 'offer': the method is declared in an interface type 69

org/dbunit/util/concurrent/Sync.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'acquire': the method is declared in an interface type 273
UnnecessaryModifier Unnecessary modifier 'public' on method 'attempt': the method is declared in an interface type 299
UnnecessaryModifier Unnecessary modifier 'public' on method 'release': the method is declared in an interface type 313
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_SECOND': the field is declared in an interface type 316
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_MINUTE': the field is declared in an interface type 319
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_HOUR': the field is declared in an interface type 322
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_DAY': the field is declared in an interface type 325
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_WEEK': the field is declared in an interface type 328
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_YEAR': the field is declared in an interface type 334
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_CENTURY': the field is declared in an interface type 337

org/dbunit/util/concurrent/Takable.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'take': the method is declared in an interface type 46
UnnecessaryModifier Unnecessary modifier 'public' on method 'poll': the method is declared in an interface type 65

org/dbunit/util/xml/XmlWriter.java

Rule Violation Line
UnconditionalIfStatement Do not use if statements that are always true or always false 383386
UnusedPrivateMethod Avoid unused private methods such as 'replace(String, String, String)'. 788
UnusedPrivateMethod Avoid unused private methods such as 'setEncoding(String)'. 825

Priority 4

org/dbunit/ant/AbstractStep.java

Rule Violation Line
UselessParentheses Useless parentheses around `((QuerySet) item).getQueryDataSet(connection)`. 143

org/dbunit/ant/Compare.java

Rule Violation Line
UselessParentheses Useless parentheses around `_src == null ? "null" : _src.getAbsolutePath()`. 181

org/dbunit/ant/Operation.java

Rule Violation Line
UselessParentheses Useless parentheses around `_transaction ? new TransactionOperation(_operat...`. 215

org/dbunit/database/DatabaseConfig.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'findByName' is already in scope 335
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'findByShortName' is already in scope 339
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'ALL_PROPERTIES' is already in scope because it is declared in an enclosing type 446
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'ALL_PROPERTIES' is already in scope because it is declared in an enclosing type 447
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'ALL_PROPERTIES' is already in scope because it is declared in an enclosing type 450
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'PROPERTY_FETCH_SIZE' is already in scope because it is declared in an enclosing type 588

org/dbunit/database/DatabaseTableMetaData.java

Rule Violation Line
UselessParentheses Useless parentheses around `keyFilter != lastKeyFilter`. 369

org/dbunit/database/PrimaryKeyFilter.java

Rule Violation Line
UselessParentheses Useless parentheses around `pksPerTable != null && pksPerTable.contains(pkO...`. 485

org/dbunit/database/ResultSetTableMetaData.java

Rule Violation Line
UselessParentheses Useless parentheses around `value == null ? null : value.trim()`. 295

org/dbunit/dataset/Column.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Column': 'NO_NULLS' is already in scope because it is declared in an enclosing type 162
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AutoIncrement': 'UNKNOWN' is already in scope because it is declared in an enclosing type 416
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AutoIncrement': 'YES' is already in scope because it is declared in an enclosing type 422
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AutoIncrement': 'NO' is already in scope because it is declared in an enclosing type 426

org/dbunit/dataset/Columns.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Columns': 'getColumn' is already in scope 82
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Columns': 'getColumn' is already in scope 185
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Columns': 'getColumnNamesAsString' is already in scope 463
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Columns': 'getColumnNamesAsString' is already in scope 471

org/dbunit/dataset/common/handlers/EnforceHandler.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'EnforceHandler': 'ENFORCE' is already in scope 51

org/dbunit/dataset/common/handlers/EscapeHandler.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'EscapeHandler': 'ACCEPT' is already in scope 85

org/dbunit/dataset/common/handlers/IsAlnumHandler.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'IsAlnumHandler': 'ACCEPT' is already in scope 94

org/dbunit/dataset/common/handlers/QuoteHandler.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'QuoteHandler': 'UNQUOTE' is already in scope 96

org/dbunit/dataset/csv/CsvProducer.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'CsvProducer': 'getTables' is already in scope 89
UselessParentheses Useless parentheses around `(List) readData.get(0)`. 113

org/dbunit/dataset/datatype/BigIntegerDataType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 82

org/dbunit/dataset/datatype/BooleanDataType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DataType': 'INTEGER' is already in scope because it is inherited by an enclosing type 95

org/dbunit/dataset/datatype/DataType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DataType': 'VARCHAR' is already in scope because it is declared in an enclosing type 190

org/dbunit/dataset/datatype/DoubleDataType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 68

org/dbunit/dataset/datatype/FloatDataType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 73

org/dbunit/dataset/datatype/IntegerDataType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 91

org/dbunit/dataset/datatype/LongDataType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 69

org/dbunit/dataset/datatype/NumberDataType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 77

org/dbunit/dataset/datatype/StringDataType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 86

org/dbunit/dataset/datatype/TimeDataType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 67
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 75
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 81
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 95
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 104
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 142

org/dbunit/dataset/datatype/TimestampDataType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 76
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 84
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 90
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 104
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 127
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 137
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'TimeZone' is already in scope because it is imported in this file 149
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 209

org/dbunit/dataset/datatype/ToleratedDeltaMap.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ToleratedDeltaMap': 'buildMapKey' is already in scope 63
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ToleratedDeltaMap': 'buildMapKey' is already in scope 101

org/dbunit/dataset/datatype/TypeCastException.java

Rule Violation Line
UselessParentheses Useless parentheses around `value == null ? "null" : value.getClass().getNa...`. 63

org/dbunit/dataset/excel/XlsTable.java

Rule Violation Line
UnnecessaryImport Unused import 'java.util.TimeZone' 29
UselessParentheses Useless parentheses around `formatString != null`. 260

org/dbunit/dataset/filter/PatternMatcher.java

Rule Violation Line
UselessParentheses Useless parentheses around `patIdxTmp - patIdxStart - 1`. 257
UselessParentheses Useless parentheses around `strIdxEnd - strIdxStart + 1`. 258

org/dbunit/dataset/sqlloader/SqlLoaderControlParserImpl.java

Rule Violation Line
UselessParentheses Useless parentheses around `fc.size()`. 173

org/dbunit/dataset/sqlloader/SqlLoaderControlProducer.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SqlLoaderControlProducer': 'getTables' is already in scope 105
UselessParentheses Useless parentheses around `(List) readData.get(0)`. 178

org/dbunit/dataset/xml/FlatDtdProducer.java

Rule Violation Line
UselessParentheses Useless parentheses around `REQUIRED.equals(mode)`. 228

org/dbunit/dataset/xml/XmlDataSet.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XmlDataSet': 'write' is already in scope 92

org/dbunit/dataset/xml/XmlProducer.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XmlProducer': 'buildException' is already in scope 146
UselessParentheses Useless parentheses around `new InputSource(in)`. 196

org/dbunit/ext/mckoi/MckoiDataTypeFactory.java

Rule Violation Line
UselessParentheses Useless parentheses around `sqlTypeName.equals("BOOLEAN")`. 70
UselessParentheses Useless parentheses around `sqlTypeName.equals("CHAR")`. 71
UselessParentheses Useless parentheses around `sqlTypeName.equals("CHARACTER")`. 72
UselessParentheses Useless parentheses around `sqlTypeName.equals("VARCHAR")`. 74
UselessParentheses Useless parentheses around `sqlTypeName.equals("LONGVARCHAR")`. 75
UselessParentheses Useless parentheses around `sqlTypeName.equals("CHARACTER VARYING")`. 76
UselessParentheses Useless parentheses around `sqlTypeName.equals("LONG CHARACTER VARYING")`. 77
UselessParentheses Useless parentheses around `sqlTypeName.equals("TEXT")`. 78
UselessParentheses Useless parentheses around `sqlTypeName.equals("STRING")`. 79
UselessParentheses Useless parentheses around `sqlTypeName.equals("CLOB")`. 81
UselessParentheses Useless parentheses around `sqlTypeName.equals("TINYINT")`. 82
UselessParentheses Useless parentheses around `sqlTypeName.equals("SMALLINT")`. 83
UselessParentheses Useless parentheses around `sqlTypeName.equals("INTEGER")`. 84
UselessParentheses Useless parentheses around `sqlTypeName.equals("INT")`. 85
UselessParentheses Useless parentheses around `sqlTypeName.equals("BIGINT")`. 87
UselessParentheses Useless parentheses around `sqlTypeName.equals("FLOAT")`. 88
UselessParentheses Useless parentheses around `sqlTypeName.equals("DOUBLE")`. 89
UselessParentheses Useless parentheses around `sqlTypeName.equals("REAL")`. 90
UselessParentheses Useless parentheses around `sqlTypeName.equals("NUMERIC")`. 91
UselessParentheses Useless parentheses around `sqlTypeName.equals("DECIMAL")`. 92
UselessParentheses Useless parentheses around `sqlTypeName.equals("DATE")`. 93
UselessParentheses Useless parentheses around `sqlTypeName.equals("TIME")`. 94
UselessParentheses Useless parentheses around `sqlTypeName.equals("TIMESTAMP")`. 95
UselessParentheses Useless parentheses around `sqlTypeName.equals("BINARY")`. 97
UselessParentheses Useless parentheses around `sqlTypeName.equals("VARBINARY")`. 98
UselessParentheses Useless parentheses around `sqlTypeName.equals("LONGVARBINARY")`. 99
UselessParentheses Useless parentheses around `sqlTypeName.equals("BLOB")`. 100
UselessParentheses Useless parentheses around `sqlTypeName.equals("JAVA_OBJECT")`. 101

org/dbunit/ext/mssql/InsertIdentityOperation.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseOperation': 'DELETE_ALL' is already in scope because it is inherited by an enclosing type 76

org/dbunit/ext/oracle/OracleBlobDataType.java

Rule Violation Line
UnnecessaryImport Unused import 'oracle.sql.BLOB' 23

org/dbunit/ext/postgresql/PostgreSQLOidDataType.java

Rule Violation Line
UselessParentheses Useless parentheses around `connection.unwrap(PGConnection.class)`. 87

org/dbunit/operation/RefreshOperation.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseOperation': 'INSERT' is already in scope because it is inherited by an enclosing type 69
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseOperation': 'UPDATE' is already in scope because it is inherited by an enclosing type 70

org/dbunit/util/Base64.java

Rule Violation Line
UselessParentheses Useless parentheses around `source[srcOffset] << 24`. 250
UselessParentheses Useless parentheses around `source[srcOffset + 1] << 24`. 251
UselessParentheses Useless parentheses around `source[srcOffset + 2] << 24`. 252
UselessParentheses Useless parentheses around `inBuff`. 260
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'ENCODE' is already in scope because it is declared in an enclosing type 305
UselessParentheses Useless parentheses around `len43`. 380
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset]] << 24`. 487
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 1]] << 24`. 488
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset]] << 24`. 497
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 1]] << 24`. 498
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 2]] << 24`. 499
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset]] << 24`. 509
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 1]] << 24`. 510
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 2]] << 24`. 511
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 3]] << 24`. 512
UselessParentheses Useless parentheses around `outBuff`. 516
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'DECODE' is already in scope because it is declared in an enclosing type 714
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'ENCODE' is already in scope because it is declared in an enclosing type 911
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'encode3to4' is already in scope 958
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'decode4to3' is already in scope 968
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'encode3to4' is already in scope 1012

org/dbunit/util/SQLHelper.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SQLHelper': 'close' is already in scope 92
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SQLHelper': 'close' is already in scope 94
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SQLHelper': 'close' is already in scope 231
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SQLHelper': 'close' is already in scope 262
UselessParentheses Useless parentheses around `dbProductName != null && dbProductName.equals(D...`. 365
UselessParentheses Useless parentheses around `tableName.startsWith(dbIdentifierQuoteString)`. 648

org/dbunit/util/concurrent/SemaphoreControlledChannel.java

Rule Violation Line
UselessParentheses Useless parentheses around `ctor.newInstance(cap)`. 85
UselessParentheses Useless parentheses around `ctor.newInstance(zero)`. 87
UselessParentheses Useless parentheses around `takeGuard_.permits()`. 104

org/dbunit/util/concurrent/SynchronizedInt.java

Rule Violation Line
UselessParentheses Useless parentheses around `assumedValue == value_`. 85

org/dbunit/util/xml/XmlWriter.java

Rule Violation Line
UselessParentheses Useless parentheses around `(0x20 <= c && c <= 0xd7ff) || (0xe000 <= c && c...`. 783784

Files

org/dbunit/IOperationListener.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'connectionRetrieved': the method is declared in an interface type 3 44
UnnecessaryModifier Unnecessary modifier 'public' on method 'operationSetUpFinished': the method is declared in an interface type 3 51
UnnecessaryModifier Unnecessary modifier 'public' on method 'operationTearDownFinished': the method is declared in an interface type 3 58
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_OP_OPERATION_LISTENER': the field is declared in an interface type 3 68

org/dbunit/ant/AbstractStep.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `((QuerySet) item).getQueryDataSet(connection)`. 4 143

org/dbunit/ant/Compare.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `_src == null ? "null" : _src.getAbsolutePath()`. 4 181

org/dbunit/ant/DbUnitTask.java

Rule Violation Priority Line
PrimitiveWrapperInstantiation Do not use `new Integer(...)`, prefer `Integer.valueOf(...)` 3 556
PrimitiveWrapperInstantiation Do not use `new Integer(...)`, prefer `Integer.valueOf(...)` 3 561

org/dbunit/ant/DbUnitTaskStep.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'execute': the method is declared in an interface type 3 38
UnnecessaryModifier Unnecessary modifier 'public' on method 'getLogMessage': the method is declared in an interface type 3 40

org/dbunit/ant/Operation.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `_transaction ? new TransactionOperation(_operat...`. 4 215

org/dbunit/assertion/DifferenceListener.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'handle': the method is declared in an interface type 3 43

org/dbunit/assertion/FailureFactory.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'createFailure': the method is declared in an interface type 3 43
UnnecessaryModifier Unnecessary modifier 'public' on method 'createFailure': the method is declared in an interface type 3 50

org/dbunit/assertion/FailureHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getAdditionalInfo': the method is declared in an interface type 3 46

org/dbunit/database/DatabaseConfig.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 265268
UnnecessaryReturn Unnecessary return statement 3 294
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'findByName' is already in scope 4 335
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'findByShortName' is already in scope 4 339
PrimitiveWrapperInstantiation Do not use `new Integer(...)`, prefer `Integer.valueOf(...)` 3 386
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'ALL_PROPERTIES' is already in scope because it is declared in an enclosing type 4 446
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'ALL_PROPERTIES' is already in scope because it is declared in an enclosing type 4 447
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'ALL_PROPERTIES' is already in scope because it is declared in an enclosing type 4 450
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'PROPERTY_FETCH_SIZE' is already in scope because it is declared in an enclosing type 4 588

org/dbunit/database/DatabaseDataSet.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 401404

org/dbunit/database/DatabaseTableMetaData.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `keyFilter != lastKeyFilter`. 4 369

org/dbunit/database/IDatabaseConnection.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getConnection': the method is declared in an interface type 3 45
UnnecessaryModifier Unnecessary modifier 'public' on method 'getSchema': the method is declared in an interface type 3 50
UnnecessaryModifier Unnecessary modifier 'public' on method 'close': the method is declared in an interface type 3 55
UnnecessaryModifier Unnecessary modifier 'public' on method 'createDataSet': the method is declared in an interface type 3 60
UnnecessaryModifier Unnecessary modifier 'public' on method 'createDataSet': the method is declared in an interface type 3 70
UnnecessaryModifier Unnecessary modifier 'public' on method 'createQueryTable': the method is declared in an interface type 3 83
UnnecessaryModifier Unnecessary modifier 'public' on method 'createTable': the method is declared in an interface type 3 96
UnnecessaryModifier Unnecessary modifier 'public' on method 'createTable': the method is declared in an interface type 3 105
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRowCount': the method is declared in an interface type 3 114
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRowCount': the method is declared in an interface type 3 123
UnnecessaryModifier Unnecessary modifier 'public' on method 'getConfig': the method is declared in an interface type 3 128
UnnecessaryModifier Unnecessary modifier 'public' on method 'getStatementFactory': the method is declared in an interface type 3 133

org/dbunit/database/IMetadataHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'matches': the method is declared in an interface type 3 63
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPrimaryKeys': the method is declared in an interface type 3 126

org/dbunit/database/IResultSetTable.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'close': the method is declared in an interface type 3 34

org/dbunit/database/IResultSetTableFactory.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'createTable': the method is declared in an interface type 3 37
UnnecessaryModifier Unnecessary modifier 'public' on method 'createTable': the method is declared in an interface type 3 40
UnnecessaryModifier Unnecessary modifier 'public' on method 'createTable': the method is declared in an interface type 3 51

org/dbunit/database/PrimaryKeyFilter.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `pksPerTable != null && pksPerTable.contains(pkO...`. 4 485

org/dbunit/database/ResultSetTableMetaData.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `value == null ? null : value.trim()`. 4 295

org/dbunit/database/ScrollableResultSetTable.java

Rule Violation Priority Line
CheckResultSet Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 3 61
CheckResultSet Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 3 83
CheckResultSet Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 3 105

org/dbunit/dataset/Column.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Column': 'NO_NULLS' is already in scope because it is declared in an enclosing type 4 162
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AutoIncrement': 'UNKNOWN' is already in scope because it is declared in an enclosing type 4 416
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AutoIncrement': 'YES' is already in scope because it is declared in an enclosing type 4 422
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AutoIncrement': 'NO' is already in scope because it is declared in an enclosing type 4 426

org/dbunit/dataset/Columns.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Columns': 'getColumn' is already in scope 4 82
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Columns': 'getColumn' is already in scope 4 185
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Columns': 'getColumnNamesAsString' is already in scope 4 463
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Columns': 'getColumnNamesAsString' is already in scope 4 471

org/dbunit/dataset/CompositeDataSet.java

Rule Violation Priority Line
UnnecessaryReturn Unnecessary return statement 3 216

org/dbunit/dataset/DefaultTable.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 144148

org/dbunit/dataset/IDataSet.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableNames': the method is declared in an interface type 3 38
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableMetaData': the method is declared in an interface type 3 49
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTable': the method is declared in an interface type 3 61
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTables': the method is declared in an interface type 3 69
UnnecessaryModifier Unnecessary modifier 'public' on method 'iterator': the method is declared in an interface type 3 74
UnnecessaryModifier Unnecessary modifier 'public' on method 'reverseIterator': the method is declared in an interface type 3 79
UnnecessaryModifier Unnecessary modifier 'public' on method 'isCaseSensitiveTableNames': the method is declared in an interface type 3 86

org/dbunit/dataset/IRowValueProvider.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getColumnValue': the method is declared in an interface type 3 40

org/dbunit/dataset/ITable.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_VALUE': the field is declared in an interface type 3 34
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableMetaData': the method is declared in an interface type 3 39
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRowCount': the method is declared in an interface type 3 44
UnnecessaryModifier Unnecessary modifier 'public' on method 'getValue': the method is declared in an interface type 3 57

org/dbunit/dataset/ITableIterator.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'next': the method is declared in an interface type 3 39
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableMetaData': the method is declared in an interface type 3 44
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTable': the method is declared in an interface type 3 49

org/dbunit/dataset/ITableMetaData.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableName': the method is declared in an interface type 3 38
UnnecessaryModifier Unnecessary modifier 'public' on method 'getColumns': the method is declared in an interface type 3 50
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPrimaryKeys': the method is declared in an interface type 3 57
UnnecessaryModifier Unnecessary modifier 'public' on method 'getColumnIndex': the method is declared in an interface type 3 67

org/dbunit/dataset/common/handlers/AbstractPipelineComponent.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 9192

org/dbunit/dataset/common/handlers/EnforceHandler.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'EnforceHandler': 'ENFORCE' is already in scope 4 51

org/dbunit/dataset/common/handlers/EscapeHandler.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'EscapeHandler': 'ACCEPT' is already in scope 4 85

org/dbunit/dataset/common/handlers/Handler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'handle': the method is declared in an interface type 3 32
UnnecessaryModifier Unnecessary modifier 'public' on method 'canHandle': the method is declared in an interface type 3 33
UnnecessaryModifier Unnecessary modifier 'public' on method 'noMoreInput': the method is declared in an interface type 3 34
UnnecessaryModifier Unnecessary modifier 'public' on method 'allowForNoMoreInput': the method is declared in an interface type 3 35

org/dbunit/dataset/common/handlers/IsAlnumHandler.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'IsAlnumHandler': 'ACCEPT' is already in scope 4 94

org/dbunit/dataset/common/handlers/QuoteHandler.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'QuoteHandler': 'UNQUOTE' is already in scope 4 96

org/dbunit/dataset/common/handlers/WhitespacesHandler.java

Rule Violation Priority Line
SimplifiedTernary This conditional expression can be simplified with || or && 3 59

org/dbunit/dataset/csv/CsvProducer.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'CsvProducer': 'getTables' is already in scope 4 89
UselessParentheses Useless parentheses around `(List) readData.get(0)`. 4 113

org/dbunit/dataset/datatype/BigIntegerDataType.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 4 82

org/dbunit/dataset/datatype/BooleanDataType.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DataType': 'INTEGER' is already in scope because it is inherited by an enclosing type 4 95

org/dbunit/dataset/datatype/DataType.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DataType': 'VARCHAR' is already in scope because it is declared in an enclosing type 4 190

org/dbunit/dataset/datatype/DateDataType.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 108111

org/dbunit/dataset/datatype/DoubleDataType.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 4 68

org/dbunit/dataset/datatype/FloatDataType.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 4 73

org/dbunit/dataset/datatype/IDataTypeFactory.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'createDataType': the method is declared in an interface type 3 41
UnnecessaryModifier Unnecessary modifier 'public' on method 'createDataType': the method is declared in an interface type 3 65

org/dbunit/dataset/datatype/IDbProductRelatable.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getValidDbProducts': the method is declared in an interface type 3 43

org/dbunit/dataset/datatype/IntegerDataType.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 4 91

org/dbunit/dataset/datatype/LongDataType.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 4 69

org/dbunit/dataset/datatype/NumberDataType.java

Rule Violation Priority Line
AvoidDecimalLiteralsInBigDecimalConstructor Avoid creating BigDecimal with a decimal (float/double) literal. Use a String literal 3 43
AvoidDecimalLiteralsInBigDecimalConstructor Avoid creating BigDecimal with a decimal (float/double) literal. Use a String literal 3 44
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 4 77

org/dbunit/dataset/datatype/StringDataType.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 4 86

org/dbunit/dataset/datatype/TimeDataType.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 4 67
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 4 75
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 4 81
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 4 95
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 4 104
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 4 142

org/dbunit/dataset/datatype/TimestampDataType.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 4 76
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 4 84
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 4 90
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 4 104
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 4 127
EmptyCatchBlock Avoid empty catch blocks 3 128131
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 4 137
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'TimeZone' is already in scope because it is imported in this file 4 149
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 4 209

org/dbunit/dataset/datatype/ToleratedDeltaMap.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ToleratedDeltaMap': 'buildMapKey' is already in scope 4 63
UnnecessaryModifier Unnecessary modifier 'final' on method 'getToleratedDeltasNullSafe': private methods cannot be overridden 3 68
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ToleratedDeltaMap': 'buildMapKey' is already in scope 4 101

org/dbunit/dataset/datatype/TypeCastException.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `value == null ? "null" : value.getClass().getNa...`. 4 63

org/dbunit/dataset/excel/XlsTable.java

Rule Violation Priority Line
UnnecessaryImport Unused import 'java.util.TimeZone' 4 29
UselessParentheses Useless parentheses around `formatString != null`. 4 260
CollapsibleIfStatements This if statement could be combined with its parent 3 262266

org/dbunit/dataset/filter/IColumnFilter.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'accept': the method is declared in an interface type 3 46

org/dbunit/dataset/filter/IRowFilter.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'accept': the method is declared in an interface type 3 39

org/dbunit/dataset/filter/ITableFilter.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableNames': the method is declared in an interface type 3 43
UnnecessaryModifier Unnecessary modifier 'public' on method 'iterator': the method is declared in an interface type 3 50

org/dbunit/dataset/filter/ITableFilterSimple.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'accept': the method is declared in an interface type 3 38

org/dbunit/dataset/filter/PatternMatcher.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `patIdxTmp - patIdxStart - 1`. 4 257
UselessParentheses Useless parentheses around `strIdxEnd - strIdxStart + 1`. 4 258
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 281

org/dbunit/dataset/sqlloader/SqlLoaderControlParserImpl.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `fc.size()`. 4 173

org/dbunit/dataset/sqlloader/SqlLoaderControlProducer.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SqlLoaderControlProducer': 'getTables' is already in scope 4 105
UselessParentheses Useless parentheses around `(List) readData.get(0)`. 4 178

org/dbunit/dataset/stream/IDataSetConsumer.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'startDataSet': the method is declared in an interface type 3 40
UnnecessaryModifier Unnecessary modifier 'public' on method 'endDataSet': the method is declared in an interface type 3 46
UnnecessaryModifier Unnecessary modifier 'public' on method 'startTable': the method is declared in an interface type 3 55
UnnecessaryModifier Unnecessary modifier 'public' on method 'endTable': the method is declared in an interface type 3 60
UnnecessaryModifier Unnecessary modifier 'public' on method 'row': the method is declared in an interface type 3 67

org/dbunit/dataset/stream/IDataSetProducer.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setConsumer': the method is declared in an interface type 3 35
UnnecessaryModifier Unnecessary modifier 'public' on method 'produce': the method is declared in an interface type 3 46

org/dbunit/dataset/stream/StreamingIterator.java

Rule Violation Priority Line
EmptyControlStatement Empty while statement 3 120121

org/dbunit/dataset/xml/FlatDtdProducer.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `REQUIRED.equals(mode)`. 4 228

org/dbunit/dataset/xml/XmlDataSet.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XmlDataSet': 'write' is already in scope 4 92

org/dbunit/dataset/xml/XmlProducer.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XmlProducer': 'buildException' is already in scope 4 146
UselessParentheses Useless parentheses around `new InputSource(in)`. 4 196
UnnecessaryReturn Unnecessary return statement 3 265
UnnecessaryReturn Unnecessary return statement 3 345

org/dbunit/ext/db2/Db2MetadataHandler.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 97103

org/dbunit/ext/mckoi/MckoiDataTypeFactory.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `sqlTypeName.equals("BOOLEAN")`. 4 70
UselessParentheses Useless parentheses around `sqlTypeName.equals("CHAR")`. 4 71
UselessParentheses Useless parentheses around `sqlTypeName.equals("CHARACTER")`. 4 72
UselessParentheses Useless parentheses around `sqlTypeName.equals("VARCHAR")`. 4 74
UselessParentheses Useless parentheses around `sqlTypeName.equals("LONGVARCHAR")`. 4 75
UselessParentheses Useless parentheses around `sqlTypeName.equals("CHARACTER VARYING")`. 4 76
UselessParentheses Useless parentheses around `sqlTypeName.equals("LONG CHARACTER VARYING")`. 4 77
UselessParentheses Useless parentheses around `sqlTypeName.equals("TEXT")`. 4 78
UselessParentheses Useless parentheses around `sqlTypeName.equals("STRING")`. 4 79
UselessParentheses Useless parentheses around `sqlTypeName.equals("CLOB")`. 4 81
UselessParentheses Useless parentheses around `sqlTypeName.equals("TINYINT")`. 4 82
UselessParentheses Useless parentheses around `sqlTypeName.equals("SMALLINT")`. 4 83
UselessParentheses Useless parentheses around `sqlTypeName.equals("INTEGER")`. 4 84
UselessParentheses Useless parentheses around `sqlTypeName.equals("INT")`. 4 85
UselessParentheses Useless parentheses around `sqlTypeName.equals("BIGINT")`. 4 87
UselessParentheses Useless parentheses around `sqlTypeName.equals("FLOAT")`. 4 88
UselessParentheses Useless parentheses around `sqlTypeName.equals("DOUBLE")`. 4 89
UselessParentheses Useless parentheses around `sqlTypeName.equals("REAL")`. 4 90
UselessParentheses Useless parentheses around `sqlTypeName.equals("NUMERIC")`. 4 91
UselessParentheses Useless parentheses around `sqlTypeName.equals("DECIMAL")`. 4 92
UselessParentheses Useless parentheses around `sqlTypeName.equals("DATE")`. 4 93
UselessParentheses Useless parentheses around `sqlTypeName.equals("TIME")`. 4 94
UselessParentheses Useless parentheses around `sqlTypeName.equals("TIMESTAMP")`. 4 95
UselessParentheses Useless parentheses around `sqlTypeName.equals("BINARY")`. 4 97
UselessParentheses Useless parentheses around `sqlTypeName.equals("VARBINARY")`. 4 98
UselessParentheses Useless parentheses around `sqlTypeName.equals("LONGVARBINARY")`. 4 99
UselessParentheses Useless parentheses around `sqlTypeName.equals("BLOB")`. 4 100
UselessParentheses Useless parentheses around `sqlTypeName.equals("JAVA_OBJECT")`. 4 101

org/dbunit/ext/mssql/InsertIdentityOperation.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseOperation': 'DELETE_ALL' is already in scope because it is inherited by an enclosing type 4 76

org/dbunit/ext/mssql/MsSqlDataTypeFactory.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 7578

org/dbunit/ext/mysql/MySqlDataTypeFactory.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 99101

org/dbunit/ext/oracle/OracleBlobDataType.java

Rule Violation Priority Line
UnnecessaryImport Unused import 'oracle.sql.BLOB' 4 23

org/dbunit/ext/postgresql/PostgreSQLOidDataType.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `connection.unwrap(PGConnection.class)`. 4 87

org/dbunit/operation/AbstractBatchOperation.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 226232

org/dbunit/operation/RefreshOperation.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseOperation': 'INSERT' is already in scope because it is inherited by an enclosing type 4 69
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseOperation': 'UPDATE' is already in scope because it is inherited by an enclosing type 4 70
EmptyCatchBlock Avoid empty catch blocks 3 119125
CheckResultSet Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 3 363

org/dbunit/util/Base64.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'BAD_ENCODING'. 3 124
UnusedLocalVariable Avoid unused local variables such as 'ib'. 3 154
EmptyControlStatement Empty while statement 3 155157
UnusedPrivateMethod Avoid unused private methods such as 'encode3to4(byte[])'. 3 179
UselessParentheses Useless parentheses around `source[srcOffset] << 24`. 4 250
UselessParentheses Useless parentheses around `source[srcOffset + 1] << 24`. 4 251
UselessParentheses Useless parentheses around `source[srcOffset + 2] << 24`. 4 252
UselessParentheses Useless parentheses around `inBuff`. 4 260
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'ENCODE' is already in scope because it is declared in an enclosing type 4 305
UselessParentheses Useless parentheses around `len43`. 4 380
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset]] << 24`. 4 487
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 1]] << 24`. 4 488
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset]] << 24`. 4 497
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 1]] << 24`. 4 498
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 2]] << 24`. 4 499
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset]] << 24`. 4 509
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 1]] << 24`. 4 510
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 2]] << 24`. 4 511
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 3]] << 24`. 4 512
UselessParentheses Useless parentheses around `outBuff`. 4 516
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'DECODE' is already in scope because it is declared in an enclosing type 4 714
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'ENCODE' is already in scope because it is declared in an enclosing type 4 911
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'encode3to4' is already in scope 4 958
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'decode4to3' is already in scope 4 968
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'encode3to4' is already in scope 4 1012

org/dbunit/util/CollectionsHelper.java

Rule Violation Priority Line
UnnecessarySemicolon Unnecessary semicolon 3 96

org/dbunit/util/SQLHelper.java

Rule Violation Priority Line
CheckResultSet Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 3 77
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SQLHelper': 'close' is already in scope 4 92
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SQLHelper': 'close' is already in scope 4 94
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SQLHelper': 'close' is already in scope 4 231
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SQLHelper': 'close' is already in scope 4 262
UselessParentheses Useless parentheses around `dbProductName != null && dbProductName.equals(D...`. 4 365
CollapsibleIfStatements This if statement could be combined with its parent 3 612613
CollapsibleIfStatements This if statement could be combined with its parent 3 629630
UnnecessaryModifier Unnecessary modifier 'final' on method 'isEscaped': private methods cannot be overridden 3 640
UselessParentheses Useless parentheses around `tableName.startsWith(dbIdentifierQuoteString)`. 4 648

org/dbunit/util/TableFormatter.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'getPadCharArray': private methods cannot be overridden 3 86
UnnecessaryModifier Unnecessary modifier 'final' on method 'pad': private methods cannot be overridden 3 104

org/dbunit/util/concurrent/BoundedChannel.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'capacity': the method is declared in an interface type 3 37

org/dbunit/util/concurrent/Channel.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'put': the method is declared in an interface type 3 249
UnnecessaryModifier Unnecessary modifier 'public' on method 'offer': the method is declared in an interface type 3 267
UnnecessaryModifier Unnecessary modifier 'public' on method 'take': the method is declared in an interface type 3 280
UnnecessaryModifier Unnecessary modifier 'public' on method 'poll': the method is declared in an interface type 3 299
UnnecessaryModifier Unnecessary modifier 'public' on method 'peek': the method is declared in an interface type 3 306

org/dbunit/util/concurrent/Executor.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'execute': the method is declared in an interface type 3 69

org/dbunit/util/concurrent/PropertyChangeMulticaster.java

Rule Violation Priority Line
PrimitiveWrapperInstantiation Do not use `new Boolean(...)`, prefer `Boolean.valueOf` 3 419
PrimitiveWrapperInstantiation Do not use `new Boolean(...)`, prefer `Boolean.valueOf` 3 420

org/dbunit/util/concurrent/Puttable.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'put': the method is declared in an interface type 3 50
UnnecessaryModifier Unnecessary modifier 'public' on method 'offer': the method is declared in an interface type 3 69

org/dbunit/util/concurrent/SemaphoreControlledChannel.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `ctor.newInstance(cap)`. 4 85
UselessParentheses Useless parentheses around `ctor.newInstance(zero)`. 4 87
UselessParentheses Useless parentheses around `takeGuard_.permits()`. 4 104

org/dbunit/util/concurrent/Sync.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'acquire': the method is declared in an interface type 3 273
UnnecessaryModifier Unnecessary modifier 'public' on method 'attempt': the method is declared in an interface type 3 299
UnnecessaryModifier Unnecessary modifier 'public' on method 'release': the method is declared in an interface type 3 313
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_SECOND': the field is declared in an interface type 3 316
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_MINUTE': the field is declared in an interface type 3 319
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_HOUR': the field is declared in an interface type 3 322
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_DAY': the field is declared in an interface type 3 325
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_WEEK': the field is declared in an interface type 3 328
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_YEAR': the field is declared in an interface type 3 334
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_CENTURY': the field is declared in an interface type 3 337

org/dbunit/util/concurrent/SynchronizedInt.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `assumedValue == value_`. 4 85

org/dbunit/util/concurrent/Takable.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'take': the method is declared in an interface type 3 46
UnnecessaryModifier Unnecessary modifier 'public' on method 'poll': the method is declared in an interface type 3 65

org/dbunit/util/xml/XmlWriter.java

Rule Violation Priority Line
UnconditionalIfStatement Do not use if statements that are always true or always false 3 383386
UselessParentheses Useless parentheses around `(0x20 <= c && c <= 0xd7ff) || (0xe000 <= c && c...`. 4 783784
UnusedPrivateMethod Avoid unused private methods such as 'replace(String, String, String)'. 3 788
UnusedPrivateMethod Avoid unused private methods such as 'setEncoding(String)'. 3 825