PMD Results

The following document contains the results of PMD 7.17.0.

Violations By Priority

Priority 2

org/dbunit/database/ResultSetTableMetaData.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 359

org/dbunit/dataset/filter/PatternMatcher.java

Rule Violation Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 282

Priority 3

org/dbunit/IOperationListener.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'connectionRetrieved': the method is declared in an interface type 44
UnnecessaryModifier Unnecessary modifier 'public' on method 'operationSetUpFinished': the method is declared in an interface type 51
UnnecessaryModifier Unnecessary modifier 'public' on method 'operationTearDownFinished': the method is declared in an interface type 58
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_OP_OPERATION_LISTENER': the field is declared in an interface type 68

org/dbunit/ant/DbUnitTask.java

Rule Violation Line
PrimitiveWrapperInstantiation Do not use `new Integer(...)`, prefer `Integer.valueOf(...)` 633
PrimitiveWrapperInstantiation Do not use `new Integer(...)`, prefer `Integer.valueOf(...)` 638

org/dbunit/ant/DbUnitTaskStep.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'execute': the method is declared in an interface type 44
UnnecessaryModifier Unnecessary modifier 'public' on method 'getLogMessage': the method is declared in an interface type 51

org/dbunit/assertion/DifferenceListener.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'handle': the method is declared in an interface type 43

org/dbunit/assertion/FailureFactory.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'createFailure': the method is declared in an interface type 43
UnnecessaryModifier Unnecessary modifier 'public' on method 'createFailure': the method is declared in an interface type 52

org/dbunit/assertion/FailureHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getAdditionalInfo': the method is declared in an interface type 46

org/dbunit/database/AbstractResultSetTable.java

Rule Violation Line
UnusedPrivateMethod Avoid unused private methods such as 'createStatement(IDatabaseConnection)'. 196

org/dbunit/database/DatabaseConfig.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 326–329
UnnecessaryReturn Unnecessary return statement 355
PrimitiveWrapperInstantiation Do not use `new Integer(...)`, prefer `Integer.valueOf(...)` 447

org/dbunit/database/DatabaseDataSet.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 507–510

org/dbunit/database/IDatabaseConnection.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getConnection': the method is declared in an interface type 48
UnnecessaryModifier Unnecessary modifier 'public' on method 'getSchema': the method is declared in an interface type 55
UnnecessaryModifier Unnecessary modifier 'public' on method 'close': the method is declared in an interface type 62
UnnecessaryModifier Unnecessary modifier 'public' on method 'createDataSet': the method is declared in an interface type 70
UnnecessaryModifier Unnecessary modifier 'public' on method 'createDataSet': the method is declared in an interface type 80
UnnecessaryModifier Unnecessary modifier 'public' on method 'createQueryTable': the method is declared in an interface type 93
UnnecessaryModifier Unnecessary modifier 'public' on method 'createTable': the method is declared in an interface type 106
UnnecessaryModifier Unnecessary modifier 'public' on method 'createTable': the method is declared in an interface type 118
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRowCount': the method is declared in an interface type 128
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRowCount': the method is declared in an interface type 138
UnnecessaryModifier Unnecessary modifier 'public' on method 'getConfig': the method is declared in an interface type 145
UnnecessaryModifier Unnecessary modifier 'public' on method 'getStatementFactory': the method is declared in an interface type 153

org/dbunit/database/IMetadataHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'matches': the method is declared in an interface type 65
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPrimaryKeys': the method is declared in an interface type 131

org/dbunit/database/IResultSetTable.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'close': the method is declared in an interface type 41

org/dbunit/database/IResultSetTableFactory.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'createTable': the method is declared in an interface type 48
UnnecessaryModifier Unnecessary modifier 'public' on method 'createTable': the method is declared in an interface type 60
UnnecessaryModifier Unnecessary modifier 'public' on method 'createTable': the method is declared in an interface type 73

org/dbunit/database/ScrollableResultSetTable.java

Rule Violation Line
CheckResultSet Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 71
CheckResultSet Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 101
CheckResultSet Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 132

org/dbunit/dataset/DefaultTable.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 159–163

org/dbunit/dataset/IDataSet.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableNames': the method is declared in an interface type 41
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableMetaData': the method is declared in an interface type 54
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTable': the method is declared in an interface type 68
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTables': the method is declared in an interface type 78
UnnecessaryModifier Unnecessary modifier 'public' on method 'iterator': the method is declared in an interface type 86
UnnecessaryModifier Unnecessary modifier 'public' on method 'reverseIterator': the method is declared in an interface type 94
UnnecessaryModifier Unnecessary modifier 'public' on method 'isCaseSensitiveTableNames': the method is declared in an interface type 101

org/dbunit/dataset/IRowValueProvider.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getColumnValue': the method is declared in an interface type 40

org/dbunit/dataset/ITable.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_VALUE': the field is declared in an interface type 35
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableMetaData': the method is declared in an interface type 42
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRowCount': the method is declared in an interface type 49
UnnecessaryModifier Unnecessary modifier 'public' on method 'getValue': the method is declared in an interface type 62

org/dbunit/dataset/ITableIterator.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'next': the method is declared in an interface type 42
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableMetaData': the method is declared in an interface type 50
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTable': the method is declared in an interface type 58

org/dbunit/dataset/ITableMetaData.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableName': the method is declared in an interface type 38
UnnecessaryModifier Unnecessary modifier 'public' on method 'getColumns': the method is declared in an interface type 50
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPrimaryKeys': the method is declared in an interface type 57
UnnecessaryModifier Unnecessary modifier 'public' on method 'getColumnIndex': the method is declared in an interface type 67

org/dbunit/dataset/common/handlers/AbstractPipelineComponent.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 103–104

org/dbunit/dataset/common/handlers/Handler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'handle': the method is declared in an interface type 42
UnnecessaryModifier Unnecessary modifier 'public' on method 'canHandle': the method is declared in an interface type 51
UnnecessaryModifier Unnecessary modifier 'public' on method 'noMoreInput': the method is declared in an interface type 58
UnnecessaryModifier Unnecessary modifier 'public' on method 'allowForNoMoreInput': the method is declared in an interface type 66

org/dbunit/dataset/common/handlers/WhitespacesHandler.java

Rule Violation Line
SimplifiedTernary This conditional expression can be simplified with || or && 71

org/dbunit/dataset/datatype/DateDataType.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 110–113

org/dbunit/dataset/datatype/IDataTypeFactory.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'createDataType': the method is declared in an interface type 43
UnnecessaryModifier Unnecessary modifier 'public' on method 'createDataType': the method is declared in an interface type 69

org/dbunit/dataset/datatype/IDbProductRelatable.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getValidDbProducts': the method is declared in an interface type 43

org/dbunit/dataset/datatype/NumberDataType.java

Rule Violation Line
AvoidDecimalLiteralsInBigDecimalConstructor Avoid creating BigDecimal with a decimal (float/double) literal. Use a String literal 45
AvoidDecimalLiteralsInBigDecimalConstructor Avoid creating BigDecimal with a decimal (float/double) literal. Use a String literal 46

org/dbunit/dataset/datatype/TimestampDataType.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 137–140

org/dbunit/dataset/datatype/ToleratedDeltaMap.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'getToleratedDeltasNullSafe': private methods cannot be overridden 68

org/dbunit/dataset/excel/XlsTable.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 277–285

org/dbunit/dataset/filter/IColumnFilter.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'accept': the method is declared in an interface type 46

org/dbunit/dataset/filter/IRowFilter.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'accept': the method is declared in an interface type 39

org/dbunit/dataset/filter/ITableFilter.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableNames': the method is declared in an interface type 45
UnnecessaryModifier Unnecessary modifier 'public' on method 'iterator': the method is declared in an interface type 55

org/dbunit/dataset/filter/ITableFilterSimple.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'accept': the method is declared in an interface type 42

org/dbunit/dataset/stream/IDataSetConsumer.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'startDataSet': the method is declared in an interface type 41
UnnecessaryModifier Unnecessary modifier 'public' on method 'endDataSet': the method is declared in an interface type 48
UnnecessaryModifier Unnecessary modifier 'public' on method 'startTable': the method is declared in an interface type 58
UnnecessaryModifier Unnecessary modifier 'public' on method 'endTable': the method is declared in an interface type 64
UnnecessaryModifier Unnecessary modifier 'public' on method 'row': the method is declared in an interface type 72

org/dbunit/dataset/stream/IDataSetProducer.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setConsumer': the method is declared in an interface type 41
UnnecessaryModifier Unnecessary modifier 'public' on method 'produce': the method is declared in an interface type 54

org/dbunit/dataset/stream/StreamingIterator.java

Rule Violation Line
EmptyControlStatement Empty while statement 126–127

org/dbunit/dataset/xml/XmlProducer.java

Rule Violation Line
UnnecessaryReturn Unnecessary return statement 275
UnnecessaryReturn Unnecessary return statement 355

org/dbunit/ext/db2/Db2MetadataHandler.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 100–106

org/dbunit/ext/mariadb/MariaDbDataTypeFactory.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 77–82

org/dbunit/ext/mssql/MsSqlDataTypeFactory.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 79–82

org/dbunit/ext/mysql/MySqlDataTypeFactory.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 101–103

org/dbunit/operation/AbstractBatchOperation.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 243–249

org/dbunit/operation/RefreshOperation.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 120–126
CheckResultSet Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 403

org/dbunit/util/Base64.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'BAD_ENCODING'. 125
UnusedLocalVariable Avoid unused local variables such as 'ib'. 160
EmptyControlStatement Empty while statement 161–163
UnusedPrivateMethod Avoid unused private methods such as 'encode3to4(byte[])'. 183

org/dbunit/util/CollectionsHelper.java

Rule Violation Line
UnnecessarySemicolon Unnecessary semicolon 96

org/dbunit/util/SQLHelper.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 618–619
CollapsibleIfStatements This if statement could be combined with its parent 635–636
UnnecessaryModifier Unnecessary modifier 'final' on method 'isEscaped': private methods cannot be overridden 646

org/dbunit/util/TableFormatter.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'getPadCharArray': private methods cannot be overridden 89
UnnecessaryModifier Unnecessary modifier 'final' on method 'pad': private methods cannot be overridden 107

org/dbunit/util/concurrent/BoundedChannel.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'capacity': the method is declared in an interface type 37

org/dbunit/util/concurrent/Channel.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'put': the method is declared in an interface type 249
UnnecessaryModifier Unnecessary modifier 'public' on method 'offer': the method is declared in an interface type 267
UnnecessaryModifier Unnecessary modifier 'public' on method 'take': the method is declared in an interface type 280
UnnecessaryModifier Unnecessary modifier 'public' on method 'poll': the method is declared in an interface type 299
UnnecessaryModifier Unnecessary modifier 'public' on method 'peek': the method is declared in an interface type 307

org/dbunit/util/concurrent/Executor.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'execute': the method is declared in an interface type 71

org/dbunit/util/concurrent/Puttable.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'put': the method is declared in an interface type 50
UnnecessaryModifier Unnecessary modifier 'public' on method 'offer': the method is declared in an interface type 69

org/dbunit/util/concurrent/Sync.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'acquire': the method is declared in an interface type 275
UnnecessaryModifier Unnecessary modifier 'public' on method 'attempt': the method is declared in an interface type 302
UnnecessaryModifier Unnecessary modifier 'public' on method 'release': the method is declared in an interface type 316
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_SECOND': the field is declared in an interface type 319
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_MINUTE': the field is declared in an interface type 322
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_HOUR': the field is declared in an interface type 325
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_DAY': the field is declared in an interface type 328
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_WEEK': the field is declared in an interface type 331
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_YEAR': the field is declared in an interface type 337
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_CENTURY': the field is declared in an interface type 340

org/dbunit/util/concurrent/Takable.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'take': the method is declared in an interface type 46
UnnecessaryModifier Unnecessary modifier 'public' on method 'poll': the method is declared in an interface type 65

org/dbunit/util/xml/XmlWriter.java

Rule Violation Line
UnconditionalIfStatement Do not use if statements that are always true or always false 410–413
UnusedPrivateMethod Avoid unused private methods such as 'replace(String, String, String)'. 884

Priority 4

org/dbunit/ant/AbstractStep.java

Rule Violation Line
UselessParentheses Useless parentheses around `((QuerySet) item).getQueryDataSet(connection)`. 161

org/dbunit/ant/Compare.java

Rule Violation Line
UselessParentheses Useless parentheses around `_src == null ? "null" : _src.getAbsolutePath()`. 213

org/dbunit/ant/Operation.java

Rule Violation Line
UselessParentheses Useless parentheses around `_transaction ? new TransactionOperation(_operat...`. 292

org/dbunit/database/DatabaseConfig.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'findByName' is already in scope 396
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'findByShortName' is already in scope 400
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'ALL_PROPERTIES' is already in scope because it is declared in an enclosing type 507
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'ALL_PROPERTIES' is already in scope because it is declared in an enclosing type 508
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'ALL_PROPERTIES' is already in scope because it is declared in an enclosing type 511
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'PROPERTY_FETCH_SIZE' is already in scope because it is declared in an enclosing type 672

org/dbunit/database/DatabaseTableMetaData.java

Rule Violation Line
UselessParentheses Useless parentheses around `keyFilter != lastKeyFilter`. 369

org/dbunit/database/PrimaryKeyFilter.java

Rule Violation Line
UselessParentheses Useless parentheses around `pksPerTable != null && pksPerTable.contains(pkO...`. 527

org/dbunit/database/ResultSetTableMetaData.java

Rule Violation Line
UselessParentheses Useless parentheses around `value == null ? null : value.trim()`. 410

org/dbunit/dataset/Column.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Column': 'NO_NULLS' is already in scope because it is declared in an enclosing type 181
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AutoIncrement': 'UNKNOWN' is already in scope because it is declared in an enclosing type 461
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AutoIncrement': 'YES' is already in scope because it is declared in an enclosing type 467
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AutoIncrement': 'NO' is already in scope because it is declared in an enclosing type 471

org/dbunit/dataset/Columns.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Columns': 'getColumn' is already in scope 84
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Columns': 'getColumn' is already in scope 187
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Columns': 'getColumnNamesAsString' is already in scope 467
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Columns': 'getColumnNamesAsString' is already in scope 477

org/dbunit/dataset/common/handlers/EnforceHandler.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'EnforceHandler': 'ENFORCE' is already in scope 60

org/dbunit/dataset/common/handlers/EscapeHandler.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'EscapeHandler': 'ACCEPT' is already in scope 104

org/dbunit/dataset/common/handlers/IsAlnumHandler.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'IsAlnumHandler': 'ACCEPT' is already in scope 113

org/dbunit/dataset/common/handlers/QuoteHandler.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'QuoteHandler': 'UNQUOTE' is already in scope 120

org/dbunit/dataset/csv/CsvProducer.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'CsvProducer': 'getTables' is already in scope 115
UselessParentheses Useless parentheses around `(List) readData.get(0)`. 139

org/dbunit/dataset/datatype/BigIntegerDataType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 85

org/dbunit/dataset/datatype/BooleanDataType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DataType': 'INTEGER' is already in scope because it is inherited by an enclosing type 97

org/dbunit/dataset/datatype/DataType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DataType': 'VARCHAR' is already in scope because it is declared in an enclosing type 251

org/dbunit/dataset/datatype/DoubleDataType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 70

org/dbunit/dataset/datatype/FloatDataType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 75

org/dbunit/dataset/datatype/IntegerDataType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 93

org/dbunit/dataset/datatype/LongDataType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 71

org/dbunit/dataset/datatype/NumberDataType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 79

org/dbunit/dataset/datatype/StringDataType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 94

org/dbunit/dataset/datatype/TimeDataType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 67
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 75
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 81
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 95
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 104
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 147

org/dbunit/dataset/datatype/TimestampDataType.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 82
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 90
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 96
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 110
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 136
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 146
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'TimeZone' is already in scope because it is imported in this file 158

org/dbunit/dataset/datatype/ToleratedDeltaMap.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ToleratedDeltaMap': 'buildMapKey' is already in scope 63
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ToleratedDeltaMap': 'buildMapKey' is already in scope 106

org/dbunit/dataset/datatype/TypeCastException.java

Rule Violation Line
UselessParentheses Useless parentheses around `value == null ? "null" : value.getClass().getNa...`. 89

org/dbunit/dataset/excel/XlsTable.java

Rule Violation Line
UselessParentheses Useless parentheses around `formatString != null`. 275

org/dbunit/dataset/filter/PatternMatcher.java

Rule Violation Line
UselessParentheses Useless parentheses around `patIdxTmp - patIdxStart - 1`. 258
UselessParentheses Useless parentheses around `strIdxEnd - strIdxStart + 1`. 259

org/dbunit/dataset/sqlloader/SqlLoaderControlParserImpl.java

Rule Violation Line
UselessParentheses Useless parentheses around `fc.size()`. 180

org/dbunit/dataset/sqlloader/SqlLoaderControlProducer.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SqlLoaderControlProducer': 'getTables' is already in scope 106
UselessParentheses Useless parentheses around `(List) readData.get(0)`. 179

org/dbunit/dataset/xml/FlatDtdProducer.java

Rule Violation Line
UselessParentheses Useless parentheses around `REQUIRED.equals(mode)`. 252

org/dbunit/dataset/xml/XmlDataSet.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XmlDataSet': 'write' is already in scope 103

org/dbunit/dataset/xml/XmlProducer.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XmlProducer': 'buildException' is already in scope 156
UselessParentheses Useless parentheses around `new InputSource(in)`. 206

org/dbunit/ext/mckoi/MckoiDataTypeFactory.java

Rule Violation Line
UselessParentheses Useless parentheses around `sqlTypeName.equals("BOOLEAN")`. 68
UselessParentheses Useless parentheses around `sqlTypeName.equals("CHAR")`. 69
UselessParentheses Useless parentheses around `sqlTypeName.equals("CHARACTER")`. 70
UselessParentheses Useless parentheses around `sqlTypeName.equals("VARCHAR")`. 72
UselessParentheses Useless parentheses around `sqlTypeName.equals("LONGVARCHAR")`. 73
UselessParentheses Useless parentheses around `sqlTypeName.equals("CHARACTER VARYING")`. 74
UselessParentheses Useless parentheses around `sqlTypeName.equals("LONG CHARACTER VARYING")`. 75
UselessParentheses Useless parentheses around `sqlTypeName.equals("TEXT")`. 76
UselessParentheses Useless parentheses around `sqlTypeName.equals("STRING")`. 77
UselessParentheses Useless parentheses around `sqlTypeName.equals("CLOB")`. 79
UselessParentheses Useless parentheses around `sqlTypeName.equals("TINYINT")`. 80
UselessParentheses Useless parentheses around `sqlTypeName.equals("SMALLINT")`. 81
UselessParentheses Useless parentheses around `sqlTypeName.equals("INTEGER")`. 82
UselessParentheses Useless parentheses around `sqlTypeName.equals("INT")`. 83
UselessParentheses Useless parentheses around `sqlTypeName.equals("BIGINT")`. 85
UselessParentheses Useless parentheses around `sqlTypeName.equals("FLOAT")`. 86
UselessParentheses Useless parentheses around `sqlTypeName.equals("DOUBLE")`. 87
UselessParentheses Useless parentheses around `sqlTypeName.equals("REAL")`. 88
UselessParentheses Useless parentheses around `sqlTypeName.equals("NUMERIC")`. 89
UselessParentheses Useless parentheses around `sqlTypeName.equals("DECIMAL")`. 90
UselessParentheses Useless parentheses around `sqlTypeName.equals("DATE")`. 91
UselessParentheses Useless parentheses around `sqlTypeName.equals("TIME")`. 92
UselessParentheses Useless parentheses around `sqlTypeName.equals("TIMESTAMP")`. 93
UselessParentheses Useless parentheses around `sqlTypeName.equals("BINARY")`. 95
UselessParentheses Useless parentheses around `sqlTypeName.equals("VARBINARY")`. 96
UselessParentheses Useless parentheses around `sqlTypeName.equals("LONGVARBINARY")`. 97
UselessParentheses Useless parentheses around `sqlTypeName.equals("BLOB")`. 98
UselessParentheses Useless parentheses around `sqlTypeName.equals("JAVA_OBJECT")`. 99

org/dbunit/ext/mssql/InsertIdentityOperation.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseOperation': 'DELETE_ALL' is already in scope because it is inherited by an enclosing type 78

org/dbunit/ext/postgresql/PostgreSQLOidDataType.java

Rule Violation Line
UselessParentheses Useless parentheses around `connection.unwrap(PGConnection.class)`. 147

org/dbunit/operation/RefreshOperation.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseOperation': 'INSERT' is already in scope because it is inherited by an enclosing type 69
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseOperation': 'UPDATE' is already in scope because it is inherited by an enclosing type 70

org/dbunit/util/Base64.java

Rule Violation Line
UselessParentheses Useless parentheses around `source[srcOffset] << 24`. 254
UselessParentheses Useless parentheses around `source[srcOffset + 1] << 24`. 255
UselessParentheses Useless parentheses around `source[srcOffset + 2] << 24`. 256
UselessParentheses Useless parentheses around `inBuff`. 264
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'ENCODE' is already in scope because it is declared in an enclosing type 309
UselessParentheses Useless parentheses around `len43`. 385
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset]] << 24`. 492
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 1]] << 24`. 493
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset]] << 24`. 502
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 1]] << 24`. 503
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 2]] << 24`. 504
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset]] << 24`. 514
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 1]] << 24`. 515
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 2]] << 24`. 516
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 3]] << 24`. 517
UselessParentheses Useless parentheses around `outBuff`. 521
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'DECODE' is already in scope because it is declared in an enclosing type 718
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'ENCODE' is already in scope because it is declared in an enclosing type 915
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'encode3to4' is already in scope 962
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'decode4to3' is already in scope 972
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'encode3to4' is already in scope 1016

org/dbunit/util/SQLHelper.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SQLHelper': 'close' is already in scope 97
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SQLHelper': 'close' is already in scope 99
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SQLHelper': 'close' is already in scope 236
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SQLHelper': 'close' is already in scope 267
UselessParentheses Useless parentheses around `dbProductName != null && dbProductName.equals(D...`. 370
UselessParentheses Useless parentheses around `tableName.startsWith(dbIdentifierQuoteString)`. 654

org/dbunit/util/concurrent/SemaphoreControlledChannel.java

Rule Violation Line
UselessParentheses Useless parentheses around `ctor.newInstance(Long.valueOf(capacity))`. 90
UselessParentheses Useless parentheses around `ctor.newInstance(Long.valueOf(0L))`. 91
UselessParentheses Useless parentheses around `takeGuard_.permits()`. 110

org/dbunit/util/concurrent/SynchronizedInt.java

Rule Violation Line
UselessParentheses Useless parentheses around `assumedValue == value_`. 96

org/dbunit/util/xml/XmlWriter.java

Rule Violation Line
UselessParentheses Useless parentheses around `(0x20 <= c && c <= 0xd7ff) || (0xe000 <= c && c...`. 879–880

Files

org/dbunit/IOperationListener.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'connectionRetrieved': the method is declared in an interface type 3 44
UnnecessaryModifier Unnecessary modifier 'public' on method 'operationSetUpFinished': the method is declared in an interface type 3 51
UnnecessaryModifier Unnecessary modifier 'public' on method 'operationTearDownFinished': the method is declared in an interface type 3 58
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_OP_OPERATION_LISTENER': the field is declared in an interface type 3 68

org/dbunit/ant/AbstractStep.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `((QuerySet) item).getQueryDataSet(connection)`. 4 161

org/dbunit/ant/Compare.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `_src == null ? "null" : _src.getAbsolutePath()`. 4 213

org/dbunit/ant/DbUnitTask.java

Rule Violation Priority Line
PrimitiveWrapperInstantiation Do not use `new Integer(...)`, prefer `Integer.valueOf(...)` 3 633
PrimitiveWrapperInstantiation Do not use `new Integer(...)`, prefer `Integer.valueOf(...)` 3 638

org/dbunit/ant/DbUnitTaskStep.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'execute': the method is declared in an interface type 3 44
UnnecessaryModifier Unnecessary modifier 'public' on method 'getLogMessage': the method is declared in an interface type 3 51

org/dbunit/ant/Operation.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `_transaction ? new TransactionOperation(_operat...`. 4 292

org/dbunit/assertion/DifferenceListener.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'handle': the method is declared in an interface type 3 43

org/dbunit/assertion/FailureFactory.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'createFailure': the method is declared in an interface type 3 43
UnnecessaryModifier Unnecessary modifier 'public' on method 'createFailure': the method is declared in an interface type 3 52

org/dbunit/assertion/FailureHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getAdditionalInfo': the method is declared in an interface type 3 46

org/dbunit/database/AbstractResultSetTable.java

Rule Violation Priority Line
UnusedPrivateMethod Avoid unused private methods such as 'createStatement(IDatabaseConnection)'. 3 196

org/dbunit/database/DatabaseConfig.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 326–329
UnnecessaryReturn Unnecessary return statement 3 355
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'findByName' is already in scope 4 396
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'findByShortName' is already in scope 4 400
PrimitiveWrapperInstantiation Do not use `new Integer(...)`, prefer `Integer.valueOf(...)` 3 447
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'ALL_PROPERTIES' is already in scope because it is declared in an enclosing type 4 507
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'ALL_PROPERTIES' is already in scope because it is declared in an enclosing type 4 508
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'ALL_PROPERTIES' is already in scope because it is declared in an enclosing type 4 511
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseConfig': 'PROPERTY_FETCH_SIZE' is already in scope because it is declared in an enclosing type 4 672

org/dbunit/database/DatabaseDataSet.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 507–510

org/dbunit/database/DatabaseTableMetaData.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `keyFilter != lastKeyFilter`. 4 369

org/dbunit/database/IDatabaseConnection.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getConnection': the method is declared in an interface type 3 48
UnnecessaryModifier Unnecessary modifier 'public' on method 'getSchema': the method is declared in an interface type 3 55
UnnecessaryModifier Unnecessary modifier 'public' on method 'close': the method is declared in an interface type 3 62
UnnecessaryModifier Unnecessary modifier 'public' on method 'createDataSet': the method is declared in an interface type 3 70
UnnecessaryModifier Unnecessary modifier 'public' on method 'createDataSet': the method is declared in an interface type 3 80
UnnecessaryModifier Unnecessary modifier 'public' on method 'createQueryTable': the method is declared in an interface type 3 93
UnnecessaryModifier Unnecessary modifier 'public' on method 'createTable': the method is declared in an interface type 3 106
UnnecessaryModifier Unnecessary modifier 'public' on method 'createTable': the method is declared in an interface type 3 118
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRowCount': the method is declared in an interface type 3 128
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRowCount': the method is declared in an interface type 3 138
UnnecessaryModifier Unnecessary modifier 'public' on method 'getConfig': the method is declared in an interface type 3 145
UnnecessaryModifier Unnecessary modifier 'public' on method 'getStatementFactory': the method is declared in an interface type 3 153

org/dbunit/database/IMetadataHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'matches': the method is declared in an interface type 3 65
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPrimaryKeys': the method is declared in an interface type 3 131

org/dbunit/database/IResultSetTable.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'close': the method is declared in an interface type 3 41

org/dbunit/database/IResultSetTableFactory.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'createTable': the method is declared in an interface type 3 48
UnnecessaryModifier Unnecessary modifier 'public' on method 'createTable': the method is declared in an interface type 3 60
UnnecessaryModifier Unnecessary modifier 'public' on method 'createTable': the method is declared in an interface type 3 73

org/dbunit/database/PrimaryKeyFilter.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `pksPerTable != null && pksPerTable.contains(pkO...`. 4 527

org/dbunit/database/ResultSetTableMetaData.java

Rule Violation Priority Line
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 359
UselessParentheses Useless parentheses around `value == null ? null : value.trim()`. 4 410

org/dbunit/database/ScrollableResultSetTable.java

Rule Violation Priority Line
CheckResultSet Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 3 71
CheckResultSet Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 3 101
CheckResultSet Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 3 132

org/dbunit/dataset/Column.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Column': 'NO_NULLS' is already in scope because it is declared in an enclosing type 4 181
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AutoIncrement': 'UNKNOWN' is already in scope because it is declared in an enclosing type 4 461
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AutoIncrement': 'YES' is already in scope because it is declared in an enclosing type 4 467
UnnecessaryFullyQualifiedName Unnecessary qualifier 'AutoIncrement': 'NO' is already in scope because it is declared in an enclosing type 4 471

org/dbunit/dataset/Columns.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Columns': 'getColumn' is already in scope 4 84
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Columns': 'getColumn' is already in scope 4 187
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Columns': 'getColumnNamesAsString' is already in scope 4 467
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Columns': 'getColumnNamesAsString' is already in scope 4 477

org/dbunit/dataset/DefaultTable.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 159–163

org/dbunit/dataset/IDataSet.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableNames': the method is declared in an interface type 3 41
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableMetaData': the method is declared in an interface type 3 54
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTable': the method is declared in an interface type 3 68
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTables': the method is declared in an interface type 3 78
UnnecessaryModifier Unnecessary modifier 'public' on method 'iterator': the method is declared in an interface type 3 86
UnnecessaryModifier Unnecessary modifier 'public' on method 'reverseIterator': the method is declared in an interface type 3 94
UnnecessaryModifier Unnecessary modifier 'public' on method 'isCaseSensitiveTableNames': the method is declared in an interface type 3 101

org/dbunit/dataset/IRowValueProvider.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getColumnValue': the method is declared in an interface type 3 40

org/dbunit/dataset/ITable.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'NO_VALUE': the field is declared in an interface type 3 35
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableMetaData': the method is declared in an interface type 3 42
UnnecessaryModifier Unnecessary modifier 'public' on method 'getRowCount': the method is declared in an interface type 3 49
UnnecessaryModifier Unnecessary modifier 'public' on method 'getValue': the method is declared in an interface type 3 62

org/dbunit/dataset/ITableIterator.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'next': the method is declared in an interface type 3 42
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableMetaData': the method is declared in an interface type 3 50
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTable': the method is declared in an interface type 3 58

org/dbunit/dataset/ITableMetaData.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableName': the method is declared in an interface type 3 38
UnnecessaryModifier Unnecessary modifier 'public' on method 'getColumns': the method is declared in an interface type 3 50
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPrimaryKeys': the method is declared in an interface type 3 57
UnnecessaryModifier Unnecessary modifier 'public' on method 'getColumnIndex': the method is declared in an interface type 3 67

org/dbunit/dataset/common/handlers/AbstractPipelineComponent.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 103–104

org/dbunit/dataset/common/handlers/EnforceHandler.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'EnforceHandler': 'ENFORCE' is already in scope 4 60

org/dbunit/dataset/common/handlers/EscapeHandler.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'EscapeHandler': 'ACCEPT' is already in scope 4 104

org/dbunit/dataset/common/handlers/Handler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'handle': the method is declared in an interface type 3 42
UnnecessaryModifier Unnecessary modifier 'public' on method 'canHandle': the method is declared in an interface type 3 51
UnnecessaryModifier Unnecessary modifier 'public' on method 'noMoreInput': the method is declared in an interface type 3 58
UnnecessaryModifier Unnecessary modifier 'public' on method 'allowForNoMoreInput': the method is declared in an interface type 3 66

org/dbunit/dataset/common/handlers/IsAlnumHandler.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'IsAlnumHandler': 'ACCEPT' is already in scope 4 113

org/dbunit/dataset/common/handlers/QuoteHandler.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'QuoteHandler': 'UNQUOTE' is already in scope 4 120

org/dbunit/dataset/common/handlers/WhitespacesHandler.java

Rule Violation Priority Line
SimplifiedTernary This conditional expression can be simplified with || or && 3 71

org/dbunit/dataset/csv/CsvProducer.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'CsvProducer': 'getTables' is already in scope 4 115
UselessParentheses Useless parentheses around `(List) readData.get(0)`. 4 139

org/dbunit/dataset/datatype/BigIntegerDataType.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 4 85

org/dbunit/dataset/datatype/BooleanDataType.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DataType': 'INTEGER' is already in scope because it is inherited by an enclosing type 4 97

org/dbunit/dataset/datatype/DataType.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DataType': 'VARCHAR' is already in scope because it is declared in an enclosing type 4 251

org/dbunit/dataset/datatype/DateDataType.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 110–113

org/dbunit/dataset/datatype/DoubleDataType.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 4 70

org/dbunit/dataset/datatype/FloatDataType.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 4 75

org/dbunit/dataset/datatype/IDataTypeFactory.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'createDataType': the method is declared in an interface type 3 43
UnnecessaryModifier Unnecessary modifier 'public' on method 'createDataType': the method is declared in an interface type 3 69

org/dbunit/dataset/datatype/IDbProductRelatable.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getValidDbProducts': the method is declared in an interface type 3 43

org/dbunit/dataset/datatype/IntegerDataType.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 4 93

org/dbunit/dataset/datatype/LongDataType.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 4 71

org/dbunit/dataset/datatype/NumberDataType.java

Rule Violation Priority Line
AvoidDecimalLiteralsInBigDecimalConstructor Avoid creating BigDecimal with a decimal (float/double) literal. Use a String literal 3 45
AvoidDecimalLiteralsInBigDecimalConstructor Avoid creating BigDecimal with a decimal (float/double) literal. Use a String literal 3 46
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 4 79

org/dbunit/dataset/datatype/StringDataType.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.lang': 'NumberFormatException' is already in scope because it is declared in java.lang 4 94

org/dbunit/dataset/datatype/TimeDataType.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 4 67
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 4 75
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 4 81
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 4 95
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 4 104
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Time' is already in scope because it is imported in this file 4 147

org/dbunit/dataset/datatype/TimestampDataType.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 4 82
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 4 90
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 4 96
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 4 110
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 4 136
EmptyCatchBlock Avoid empty catch blocks 3 137–140
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.sql': 'Timestamp' is already in scope because it is imported in this file 4 146
UnnecessaryFullyQualifiedName Unnecessary qualifier 'java.util': 'TimeZone' is already in scope because it is imported in this file 4 158

org/dbunit/dataset/datatype/ToleratedDeltaMap.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ToleratedDeltaMap': 'buildMapKey' is already in scope 4 63
UnnecessaryModifier Unnecessary modifier 'final' on method 'getToleratedDeltasNullSafe': private methods cannot be overridden 3 68
UnnecessaryFullyQualifiedName Unnecessary qualifier 'ToleratedDeltaMap': 'buildMapKey' is already in scope 4 106

org/dbunit/dataset/datatype/TypeCastException.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `value == null ? "null" : value.getClass().getNa...`. 4 89

org/dbunit/dataset/excel/XlsTable.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `formatString != null`. 4 275
CollapsibleIfStatements This if statement could be combined with its parent 3 277–285

org/dbunit/dataset/filter/IColumnFilter.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'accept': the method is declared in an interface type 3 46

org/dbunit/dataset/filter/IRowFilter.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'accept': the method is declared in an interface type 3 39

org/dbunit/dataset/filter/ITableFilter.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getTableNames': the method is declared in an interface type 3 45
UnnecessaryModifier Unnecessary modifier 'public' on method 'iterator': the method is declared in an interface type 3 55

org/dbunit/dataset/filter/ITableFilterSimple.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'accept': the method is declared in an interface type 3 42

org/dbunit/dataset/filter/PatternMatcher.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `patIdxTmp - patIdxStart - 1`. 4 258
UselessParentheses Useless parentheses around `strIdxEnd - strIdxStart + 1`. 4 259
AvoidBranchingStatementAsLastInLoop Avoid using a branching statement as the last in a loop. 2 282

org/dbunit/dataset/sqlloader/SqlLoaderControlParserImpl.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `fc.size()`. 4 180

org/dbunit/dataset/sqlloader/SqlLoaderControlProducer.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SqlLoaderControlProducer': 'getTables' is already in scope 4 106
UselessParentheses Useless parentheses around `(List) readData.get(0)`. 4 179

org/dbunit/dataset/stream/IDataSetConsumer.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'startDataSet': the method is declared in an interface type 3 41
UnnecessaryModifier Unnecessary modifier 'public' on method 'endDataSet': the method is declared in an interface type 3 48
UnnecessaryModifier Unnecessary modifier 'public' on method 'startTable': the method is declared in an interface type 3 58
UnnecessaryModifier Unnecessary modifier 'public' on method 'endTable': the method is declared in an interface type 3 64
UnnecessaryModifier Unnecessary modifier 'public' on method 'row': the method is declared in an interface type 3 72

org/dbunit/dataset/stream/IDataSetProducer.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'setConsumer': the method is declared in an interface type 3 41
UnnecessaryModifier Unnecessary modifier 'public' on method 'produce': the method is declared in an interface type 3 54

org/dbunit/dataset/stream/StreamingIterator.java

Rule Violation Priority Line
EmptyControlStatement Empty while statement 3 126–127

org/dbunit/dataset/xml/FlatDtdProducer.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `REQUIRED.equals(mode)`. 4 252

org/dbunit/dataset/xml/XmlDataSet.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XmlDataSet': 'write' is already in scope 4 103

org/dbunit/dataset/xml/XmlProducer.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'XmlProducer': 'buildException' is already in scope 4 156
UselessParentheses Useless parentheses around `new InputSource(in)`. 4 206
UnnecessaryReturn Unnecessary return statement 3 275
UnnecessaryReturn Unnecessary return statement 3 355

org/dbunit/ext/db2/Db2MetadataHandler.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 100–106

org/dbunit/ext/mariadb/MariaDbDataTypeFactory.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 77–82

org/dbunit/ext/mckoi/MckoiDataTypeFactory.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `sqlTypeName.equals("BOOLEAN")`. 4 68
UselessParentheses Useless parentheses around `sqlTypeName.equals("CHAR")`. 4 69
UselessParentheses Useless parentheses around `sqlTypeName.equals("CHARACTER")`. 4 70
UselessParentheses Useless parentheses around `sqlTypeName.equals("VARCHAR")`. 4 72
UselessParentheses Useless parentheses around `sqlTypeName.equals("LONGVARCHAR")`. 4 73
UselessParentheses Useless parentheses around `sqlTypeName.equals("CHARACTER VARYING")`. 4 74
UselessParentheses Useless parentheses around `sqlTypeName.equals("LONG CHARACTER VARYING")`. 4 75
UselessParentheses Useless parentheses around `sqlTypeName.equals("TEXT")`. 4 76
UselessParentheses Useless parentheses around `sqlTypeName.equals("STRING")`. 4 77
UselessParentheses Useless parentheses around `sqlTypeName.equals("CLOB")`. 4 79
UselessParentheses Useless parentheses around `sqlTypeName.equals("TINYINT")`. 4 80
UselessParentheses Useless parentheses around `sqlTypeName.equals("SMALLINT")`. 4 81
UselessParentheses Useless parentheses around `sqlTypeName.equals("INTEGER")`. 4 82
UselessParentheses Useless parentheses around `sqlTypeName.equals("INT")`. 4 83
UselessParentheses Useless parentheses around `sqlTypeName.equals("BIGINT")`. 4 85
UselessParentheses Useless parentheses around `sqlTypeName.equals("FLOAT")`. 4 86
UselessParentheses Useless parentheses around `sqlTypeName.equals("DOUBLE")`. 4 87
UselessParentheses Useless parentheses around `sqlTypeName.equals("REAL")`. 4 88
UselessParentheses Useless parentheses around `sqlTypeName.equals("NUMERIC")`. 4 89
UselessParentheses Useless parentheses around `sqlTypeName.equals("DECIMAL")`. 4 90
UselessParentheses Useless parentheses around `sqlTypeName.equals("DATE")`. 4 91
UselessParentheses Useless parentheses around `sqlTypeName.equals("TIME")`. 4 92
UselessParentheses Useless parentheses around `sqlTypeName.equals("TIMESTAMP")`. 4 93
UselessParentheses Useless parentheses around `sqlTypeName.equals("BINARY")`. 4 95
UselessParentheses Useless parentheses around `sqlTypeName.equals("VARBINARY")`. 4 96
UselessParentheses Useless parentheses around `sqlTypeName.equals("LONGVARBINARY")`. 4 97
UselessParentheses Useless parentheses around `sqlTypeName.equals("BLOB")`. 4 98
UselessParentheses Useless parentheses around `sqlTypeName.equals("JAVA_OBJECT")`. 4 99

org/dbunit/ext/mssql/InsertIdentityOperation.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseOperation': 'DELETE_ALL' is already in scope because it is inherited by an enclosing type 4 78

org/dbunit/ext/mssql/MsSqlDataTypeFactory.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 79–82

org/dbunit/ext/mysql/MySqlDataTypeFactory.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 101–103

org/dbunit/ext/postgresql/PostgreSQLOidDataType.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `connection.unwrap(PGConnection.class)`. 4 147

org/dbunit/operation/AbstractBatchOperation.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 243–249

org/dbunit/operation/RefreshOperation.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseOperation': 'INSERT' is already in scope because it is inherited by an enclosing type 4 69
UnnecessaryFullyQualifiedName Unnecessary qualifier 'DatabaseOperation': 'UPDATE' is already in scope because it is inherited by an enclosing type 4 70
EmptyCatchBlock Avoid empty catch blocks 3 120–126
CheckResultSet Always check the return of one of the navigation method (next,previous,first,last) of a ResultSet. 3 403

org/dbunit/util/Base64.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'BAD_ENCODING'. 3 125
UnusedLocalVariable Avoid unused local variables such as 'ib'. 3 160
EmptyControlStatement Empty while statement 3 161–163
UnusedPrivateMethod Avoid unused private methods such as 'encode3to4(byte[])'. 3 183
UselessParentheses Useless parentheses around `source[srcOffset] << 24`. 4 254
UselessParentheses Useless parentheses around `source[srcOffset + 1] << 24`. 4 255
UselessParentheses Useless parentheses around `source[srcOffset + 2] << 24`. 4 256
UselessParentheses Useless parentheses around `inBuff`. 4 264
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'ENCODE' is already in scope because it is declared in an enclosing type 4 309
UselessParentheses Useless parentheses around `len43`. 4 385
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset]] << 24`. 4 492
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 1]] << 24`. 4 493
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset]] << 24`. 4 502
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 1]] << 24`. 4 503
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 2]] << 24`. 4 504
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset]] << 24`. 4 514
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 1]] << 24`. 4 515
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 2]] << 24`. 4 516
UselessParentheses Useless parentheses around `DECODABET[source[srcOffset + 3]] << 24`. 4 517
UselessParentheses Useless parentheses around `outBuff`. 4 521
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'DECODE' is already in scope because it is declared in an enclosing type 4 718
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'ENCODE' is already in scope because it is declared in an enclosing type 4 915
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'encode3to4' is already in scope 4 962
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'decode4to3' is already in scope 4 972
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Base64': 'encode3to4' is already in scope 4 1016

org/dbunit/util/CollectionsHelper.java

Rule Violation Priority Line
UnnecessarySemicolon Unnecessary semicolon 3 96

org/dbunit/util/SQLHelper.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SQLHelper': 'close' is already in scope 4 97
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SQLHelper': 'close' is already in scope 4 99
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SQLHelper': 'close' is already in scope 4 236
UnnecessaryFullyQualifiedName Unnecessary qualifier 'SQLHelper': 'close' is already in scope 4 267
UselessParentheses Useless parentheses around `dbProductName != null && dbProductName.equals(D...`. 4 370
CollapsibleIfStatements This if statement could be combined with its parent 3 618–619
CollapsibleIfStatements This if statement could be combined with its parent 3 635–636
UnnecessaryModifier Unnecessary modifier 'final' on method 'isEscaped': private methods cannot be overridden 3 646
UselessParentheses Useless parentheses around `tableName.startsWith(dbIdentifierQuoteString)`. 4 654

org/dbunit/util/TableFormatter.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on method 'getPadCharArray': private methods cannot be overridden 3 89
UnnecessaryModifier Unnecessary modifier 'final' on method 'pad': private methods cannot be overridden 3 107

org/dbunit/util/concurrent/BoundedChannel.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'capacity': the method is declared in an interface type 3 37

org/dbunit/util/concurrent/Channel.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'put': the method is declared in an interface type 3 249
UnnecessaryModifier Unnecessary modifier 'public' on method 'offer': the method is declared in an interface type 3 267
UnnecessaryModifier Unnecessary modifier 'public' on method 'take': the method is declared in an interface type 3 280
UnnecessaryModifier Unnecessary modifier 'public' on method 'poll': the method is declared in an interface type 3 299
UnnecessaryModifier Unnecessary modifier 'public' on method 'peek': the method is declared in an interface type 3 307

org/dbunit/util/concurrent/Executor.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'execute': the method is declared in an interface type 3 71

org/dbunit/util/concurrent/Puttable.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'put': the method is declared in an interface type 3 50
UnnecessaryModifier Unnecessary modifier 'public' on method 'offer': the method is declared in an interface type 3 69

org/dbunit/util/concurrent/SemaphoreControlledChannel.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `ctor.newInstance(Long.valueOf(capacity))`. 4 90
UselessParentheses Useless parentheses around `ctor.newInstance(Long.valueOf(0L))`. 4 91
UselessParentheses Useless parentheses around `takeGuard_.permits()`. 4 110

org/dbunit/util/concurrent/Sync.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'acquire': the method is declared in an interface type 3 275
UnnecessaryModifier Unnecessary modifier 'public' on method 'attempt': the method is declared in an interface type 3 302
UnnecessaryModifier Unnecessary modifier 'public' on method 'release': the method is declared in an interface type 3 316
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_SECOND': the field is declared in an interface type 3 319
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_MINUTE': the field is declared in an interface type 3 322
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_HOUR': the field is declared in an interface type 3 325
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_DAY': the field is declared in an interface type 3 328
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_WEEK': the field is declared in an interface type 3 331
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_YEAR': the field is declared in an interface type 3 337
UnnecessaryModifier Unnecessary modifiers 'public static final' on field 'ONE_CENTURY': the field is declared in an interface type 3 340

org/dbunit/util/concurrent/SynchronizedInt.java

Rule Violation Priority Line
UselessParentheses Useless parentheses around `assumedValue == value_`. 4 96

org/dbunit/util/concurrent/Takable.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'take': the method is declared in an interface type 3 46
UnnecessaryModifier Unnecessary modifier 'public' on method 'poll': the method is declared in an interface type 3 65

org/dbunit/util/xml/XmlWriter.java

Rule Violation Priority Line
UnconditionalIfStatement Do not use if statements that are always true or always false 3 410–413
UselessParentheses Useless parentheses around `(0x20 <= c && c <= 0xd7ff) || (0xe000 <= c && c...`. 4 879–880
UnusedPrivateMethod Avoid unused private methods such as 'replace(String, String, String)'. 3 884